fix(otlp_output): parse RFC 7951 numeric JSON strings as metric values - #893
Open
Mesverrum wants to merge 1 commit into
Open
fix(otlp_output): parse RFC 7951 numeric JSON strings as metric values#893Mesverrum wants to merge 1 commit into
Mesverrum wants to merge 1 commit into
Conversation
json_ietf encodes YANG uint64/int64/decimal64 as JSON strings. The OTLP converter previously treated every string as an enum (value=1 + value attribute), causing wrong Prom values and label cardinality explosion. Prefer numeric datapoints when the string parses, matching prometheus_output.
karimra
requested changes
Aug 11, 2026
karimra
left a comment
karimra
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for this. The direction is correct but it needs a small change:
The change bypasses strings-as-attributes. The default for is false, that means string values are dropped. With this change, any string that parses as a number becomes a data point, even when the option is false. So users on the default config will see new metrics that did not exist before.
I think the numeric check should run after the strings-as-attributes gate, or use its own option.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change aligns the OTEL output with the way the Prometheus output works.
json_ietf encodes YANG uint64/int64/decimal64 as JSON strings. The OTLP converter previously treated every string as an enum (value=1 + value attribute), causing wrong Prom values and label cardinality explosion. Prefer numeric datapoints when the string parses, matching prometheus_output.